Summary by CodeRabbit

Release Notes

• Bug Fixes

  • Simplified attribute case handling and enhanced normalization logic for improved consistency.

• Tests

  • Updated test cases and descriptions to reflect simplified attribute handling.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Walkthrough

This PR simplifies the attributeCases() method in EnumDataProvider by removing the asHtml parameter. The method now unconditionally returns normalized attribute values with an expanded return structure containing separate attribute fragment and message fields. Tests and documentation are updated accordingly.

Changes

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Suggested labels

bug

Poem

🐰 With asHtml gone, the path is clear,
Attributes now unified without fear,
Five values strong in structured array,
Simpler logic brightens the day! ✨

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

• 📝 Generate docstrings

src/EnumDataProvider.php (1)

40-59: LGTM on the simplification!

The removal of the asHtml parameter and consistent normalization logic simplifies the method nicely. The return structure is now consistent.

One observation: $case appears at both index 0 and index 2 in the returned array. If this is intentional for testing flexibility, consider adding a brief inline comment clarifying the purpose of each array element.

tests/Support/Provider/EnumDataProviderProvider.php (1)

20-50: Unused asHtml parameter in test data.

The asHtml boolean (index 2) is still present in the test data, but EnumDataProvider::attributeCases() no longer accepts this parameter. While the test still uses it for conditional assertions, this creates confusion as it no longer reflects the actual API behavior.

Consider removing the asHtml field from the data provider and simplifying the test to always assert the attribute fragment and message, since the method now consistently returns the same structure.

♻️ Suggested simplification

     /**
-     * `@return` array<string, array{string, string|\UnitEnum, bool, string, string, string}>
+     * `@return` array<string, array{string, string|\UnitEnum, string, string, string}>
      */
     public static function casesParameters(): array
     {
         return [
             'as enum instance' => [
                 TestEnum::class,
                 'data-test',
-                false,
                 'enum: FOO',
                 ' data-test="FOO"',
                 "Should return the 'data-test' attribute value for enum case: FOO.",
             ],
-            'as html' => [
+            'second case' => [
                 TestEnum::class,
                 'data-test',
-                true,
                 'enum: BAR',
                 ' data-test="BAR"',
                 "Should return the 'data-test' attribute value for enum case: BAR.",
             ],
             'attribute as enum instance' => [
                 TestEnum::class,
                 TestEnum::FOO,
-                true,
                 'enum: FOO',
                 ' FOO="FOO"',
                 "Should return the 'FOO' attribute value for enum case: FOO.",
             ],
         ];
     }

tests/EnumDataProviderTest.php (2)

37-45: Consider removing unused $asHtml parameter.

The $asHtml parameter is still part of the test method signature (line 40) but EnumDataProvider::attributeCases() no longer accepts it. The parameter only controls conditional assertion logic (line 62) which may no longer be meaningful since the method always returns the same structure.

---

62-74: Index access is correct; conditional assertion is now vestigial.

The updated indices [3] and [4] correctly align with the new return structure from attributeCases().

However, since attributeCases() now always returns the attribute fragment (no more asHtml branching), the if ($asHtml) conditional (line 62) is now misleading. Consider removing it and always asserting the attribute value.

♻️ Suggested simplification

-        if ($asHtml) {
-            self::assertSame(
-                $expectedAttributeCase,
-                $data[$expectedKeyCase][3],
-                'Should return expected attribute value for enum case.',
-            );
-        }
+        self::assertSame(
+            $expectedAttributeCase,
+            $data[$expectedKeyCase][3],
+            'Should return expected attribute value for enum case.',
+        );

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Learnt from: terabytesoftw
Repo: php-forge/support PR: 12
File: src/TestSupport.php:0-0
Timestamp: 2025-08-18T20:13:33.518Z
Learning: User terabytesoftw prefers clean trait-based designs over maintaining backward compatibility wrappers when refactoring utility classes in the php-forge/support project.

Learnt from: terabytesoftw
Repo: php-forge/actions PR: 65
File: .github/workflows/composer-require-checker.yml:80-83
Timestamp: 2025-09-28T15:12:48.345Z
Learning: The user terabytesoftw prefers using floating tags like v1 for third-party actions in GitHub workflows instead of pinning to specific commit SHAs, even when it's a security best practice to pin to immutable commits.

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

• X
• Mastodon
• Reddit
• LinkedIn